fix(opencode): cap retry delays without valid hints#29439
Open
Bagnesium wants to merge 4 commits into
Open
Conversation
github-actions
Bot
added
needs:title
needs:compliance
Contributor
|
Hey! Your PR title Please update it to start with one of:
Where See CONTRIBUTING.md for details. |
Bagnesium
changed the title
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
github-actions
Bot
removed
needs:compliance
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #20126
Type of change
What does this PR do?
Caps the normal retry backoff at 30 seconds even when an error response includes headers but no valid
retry-afterhint. It also ignores negative numeric retry hints so malformed headers fall back to normal backoff instead of scheduling a negative delay.How did you verify your code works?
Ran from
packages/opencode:npx --yes bun@1.3.14 test test/session/retry.test.ts npx --yes bun@1.3.14 typecheckScreenshots / recordings
Not applicable; no UI changes.
Checklist
If you do not follow this template your PR will be automatically rejected.